Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Language Tags project by migrating legacy APIs (Iso6392, Iso6393, Rfc5646) to new *Data classes, updating documentation, tests, and build/workflow configurations accordingly. Key changes include:
- Replacing legacy classes with Iso6392Data, Iso6393Data, and Rfc5646Data in both production and test code.
- Updating the README to reflect new API usage and clarifying intended limitations.
- Modifying project configurations, tasks, and GitHub Actions workflow files to support these updates.
Reviewed Changes
Copilot reviewed 23 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updated introduction, tag lookup examples, and disclaimer messaging. |
| LanguageTagsTests/* | Renamed tests and updated API calls from legacy to new *Data classes. |
| LanguageTagsCreate/Program.cs | Updated references and asynchronous file I/O for new data classes. |
| LanguageTags/*.cs (Rfc5646, Iso6392, Iso6393 files) | Legacy implementations removed in favor of new *Data implementations. |
| JsonOptions.cs | Adjusted JSON options (e.g. DefaultIgnoreCondition and NewLine settings). |
| .github/workflows/update-languagedata.yml | Modified cron schedule and minor workflow adjustments. |
| .vscode/* | Updated tasks and launch configurations to reflect new naming conventions. |
Comments suppressed due to low confidence (3)
LanguageTags/JsonOptions.cs:19
- The change from WhenWritingNull to WhenWritingDefault alters serialization behavior. Consider adding a comment explaining the rationale behind this change to help future maintainers.
DefaultIgnoreCondition = JsonIgnoreCondition.WhenWritingDefault,
README.md:32
- [nitpick] Consider clarifying this disclaimer to better inform users about current limitations and expected future improvements, which can reduce potential confusion.
Note that the implemented language tag parsing and normalization logic may be incomplete or inaccurate.
.github/workflows/update-languagedata.yml:6
- The updated cron schedule now triggers on Monday at 02:00. Confirm that this change aligns with the intended update frequency for language data.
- cron: '0 2 * * MON'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.